Skip to content
This repository has been archived by the owner on Dec 23, 2023. It is now read-only.

Monitored Resource: replace gke_container with k8s_container in SD exporter #1467

Merged
merged 3 commits into from
Sep 24, 2018
Merged

Monitored Resource: replace gke_container with k8s_container in SD exporter #1467

merged 3 commits into from
Sep 24, 2018

Conversation

mayurkale22
Copy link
Member

…porter

Fixes #1445

@mayurkale22 mayurkale22 requested a review from songy23 September 21, 2018 16:50
songy23
songy23 approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will this be a breaking change for users that already use "gke_container" resources?

@mayurkale22
Copy link
Member Author

Yes, this is breaking change for existing user. SD also mentioned same in their release doc: https://cloud.google.com/monitoring/kubernetes-engine/migration#incompatible

@songy23
Copy link
Contributor

songy23 commented Sep 21, 2018

Yes, this is breaking change for existing user. SD also mentioned same in their release doc: https://cloud.google.com/monitoring/kubernetes-engine/migration#incompatible

Please add an entry to CHANGELOG.md and point to the SD document.

@codecov-io
Copy link

codecov-io commented Sep 21, 2018 •
edited
Loading

Codecov Report

Merging #1467 into master will increase coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1467      +/-   ##
============================================
+ Coverage     82.39%   82.41%   +0.02%     
  Complexity     1542     1542              
============================================
  Files           235      235              
  Lines          7232     7229       -3     
  Branches        689      689              
============================================
- Hits           5959     5958       -1     
+ Misses         1060     1059       -1     
+ Partials        213      212       -1
Impacted Files Coverage Δ Complexity Δ
...rter/stats/stackdriver/StackdriverExportUtils.java 83% <0%> (+0.4%) 31 <0> (ø) ⬇️
...race/stackdriver/StackdriverV2ExporterHandler.java 89.44% <100%> (-0.1%) 40 <0> (ø)
...census/implcore/trace/export/SpanExporterImpl.java 93.15% <0%> (+1.36%) 8% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c988a2...64a20ce. Read the comment docs.

@mayurkale22 mayurkale22 merged commit 35c4b3d into census-instrumentation:master Sep 24, 2018
@mayurkale22 mayurkale22 deleted the k8s_container branch September 24, 2018 16:45
@mayurkale22 mayurkale22 mentioned this pull request Sep 24, 2018
Closed
@c24t c24t mentioned this pull request Feb 27, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@songy23 songy23 songy23 approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mayurkale22 @songy23 @codecov-io @googlebot